Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves issue #669 #670

Merged
merged 1 commit into from
Feb 12, 2025
Merged

resolves issue #669 #670

merged 1 commit into from
Feb 12, 2025

Conversation

infiton
Copy link
Contributor

@infiton infiton commented Feb 7, 2025

This issue resolves #669

Based on https://shopify.dev/changelog/graphql-over-http:

For requests to 2025-01 versions and after:

Use the /graphql endpoint. Using /graphql.json will automatically respond with application/json as it does now.
The request body must contain a [spec JSON encoding](https://graphql.github.io/graphql-over-http/draft/#sec-JSON-Encoding).
The Content-Type header must specify application/json. The legacy application/graphql request format is no longer supported. Requests with no supported content type will receive a 415 Unsupported Media Type response.
The Accept header now supports application/graphql-response+json and/or application/json response formats. Requests with no supported accept types will receive a 406 Not Acceptable response.

This change is backwards compatible as old api versions accept json requests like this

@infiton
Copy link
Contributor Author

infiton commented Feb 12, 2025

@lpinca any thoughts on this?

@lpinca lpinca merged commit 6cf1b53 into MONEI:master Feb 12, 2025
8 checks passed
@lpinca
Copy link
Collaborator

lpinca commented Feb 12, 2025

Thank you.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling ffa4cd1 on infiton:bug-fix-issue-669
into 48e23de on MONEI:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported Content-Type header, use application/json 2025-01
3 participants