Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp buttons on Register and Feed #141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Revamp buttons on Register and Feed #141

wants to merge 2 commits into from

Conversation

Sameerkash
Copy link
Member

@Sameerkash Sameerkash commented Apr 16, 2021 •
edited
Loading

Fixes #121

SignUp

Screen Shot 2021-04-16 at 10 54 21 PM

Image Preview
Screen Shot 2021-04-16 at 6 25 20 PM

Feed
Screen Shot 2021-04-16 at 6 34 03 PM

github-actions[bot]
github-actions bot reviewed Apr 16, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the Pull Request! Do not worry if your PR breaks things, but do raise an issue if it does. :p

@bodhisha
Copy link
Member

Hey @Sameerkash .. Thanks for creating the PR. The UI looks really amazing and clean. ❤️ Just one small suggestion on the UX part.
I feel like something should be there on the button or above to give a clear insight to the user that you are supposed to upload an image there. @aitikgupta Your views?
register

@aitikgupta
Copy link
Member

Thanks for creating the PR. The UI looks really amazing and clean. ❤️

I agreee!

I feel like something should be there on the button or above to give a clear insight to the user that you are supposed to upload an image there.

I agree, maybe a small placeholder text would solve it?

@aitikgupta aitikgupta added client Related to client-side code (Frontend) enhancement New feature or request labels Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

Assignees
No one assigned
Labels
client Related to client-side code (Frontend) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style Upload picture buttons
3 participants
@Sameerkash @bodhisha @aitikgupta