-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw away typed distributions types #108
Comments
Thanks for your feedback! |
So, are you going to implement it or do you prefer leave everything as it is? |
Thank you for the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IMHO:
StringCatHyperParameter
,IntCatHyperParameter
,FloatCatHyperParameter
are not needed. JustCatHyperParameter
.ParamTypes
is also unneeded. String is a scalar, scalar is a degenerate cathegory. Distributions should be decoupled from types, for distributionsscipy.stats
should be used, and for types ... types themselves.You may want to look at my implementation
The text was updated successfully, but these errors were encountered: