Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw away typed distributions types #108

Closed
KOLANICH opened this issue Jan 4, 2019 · 4 comments
Closed

Throw away typed distributions types #108

KOLANICH opened this issue Jan 4, 2019 · 4 comments

Comments

@KOLANICH
Copy link

KOLANICH commented Jan 4, 2019

IMHO:

StringCatHyperParameter, IntCatHyperParameter, FloatCatHyperParameter are not needed. Just CatHyperParameter.

ParamTypes is also unneeded. String is a scalar, scalar is a degenerate cathegory. Distributions should be decoupled from types, for distributions scipy.stats should be used, and for types ... types themselves.

You may want to look at my implementation

@micahjsmith
Copy link
Contributor

Thanks for your feedback!

@KOLANICH
Copy link
Author

KOLANICH commented Feb 13, 2019

So, are you going to implement it or do you prefer leave everything as it is?

@csala
Copy link
Contributor

csala commented Feb 13, 2019

Hi @KOLANICH hyperparameters will soon undergo a design review and refactoring in order to support several of the new requirements, like #80, #111, #112 and #113

So we take notes of your suggestion as well, but this stays closed for now, as it won't be implemented as something on its own.

@KOLANICH
Copy link
Author

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants