Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipc1: Is this broken or just mislabeled? #100

Open
argonaut22 opened this issue Nov 4, 2024 · 1 comment
Open

ipc1: Is this broken or just mislabeled? #100

argonaut22 opened this issue Nov 4, 2024 · 1 comment
Labels
question Further information is requested

Comments

@argonaut22
Copy link
Collaborator

Anyone know what's up with this well-advertised "hack"? Unclear if something is broken with ipc1 or if Sicheng just forgot. @askprash ?

As an aside, @aditeyashukla , assuming the flags went away as part of the fuselage struct changes, does that mean we can remove these lines?

image
@argonaut22 argonaut22 added the question Further information is requested label Nov 4, 2024
@aditeyashukla
Copy link
Contributor

The commented lines mean that these flags arent used in mission but don't necessarily mean they arent used in TASOPT
For eg:
iiengloc is used in wsize.jl
iifclose is now fuselage.layout.taper_fuse so can be purged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aditeyashukla @argonaut22