Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate facets on a sidebar with widgets in it #7

Open
modelm opened this issue Dec 18, 2017 · 1 comment
Open

Duplicate facets on a sidebar with widgets in it #7

modelm opened this issue Dec 18, 2017 · 1 comment
Labels

Comments

@modelm
Copy link
Contributor

modelm commented Dec 18, 2017

As implemented, search facets assume (and only work with) an empty sidebar. If there are widgets in the target sidebar, facets are duplicated (and probably break in other ways, not thoroughly tested). Make facets portable to ensure compatibility regardless of theme or other widgets.

This will involve replacing at least the following:

Probably best to turn this into a widget and make it optional to include on the search sidebar?

screencapture-hcommons-org-1512399771352

@modelm modelm self-assigned this Dec 18, 2017
@modelm modelm added the bug label Dec 18, 2017
@modelm modelm removed their assignment Dec 18, 2017
@modelm
Copy link
Contributor Author

modelm commented May 2, 2018

Use https://www.elasticpress.io/blog/2018/04/elasticpress-2-5-facets/ and replace existing facet widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant