Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this package mrpt free ? #9

Closed
artivis opened this issue Aug 14, 2017 · 4 comments · Fixed by #10
Closed

Make this package mrpt free ? #9

artivis opened this issue Aug 14, 2017 · 4 comments · Fixed by #10

Comments

@artivis
Copy link

artivis commented Aug 14, 2017

A quick look at the code let me think that this package depends on mrpt only for using a couple of matrix and two basic math functions.
Wouldn't it make sense to replace mrpt with plain Eigen types such as Eigen::Isometry3d thus removing a - heavy - dependency ? (Heavy regarding its use here...).

@artivis
Copy link
Author

artivis commented Aug 16, 2017

I made a mrpt-free branch on my fork. Replacing mrpt with plain Eigen.
Please let me know if you are interested in a pull request.

@JGMonroy
Copy link
Member

Hi artivis,
Hmmm what you point out may be interesting. We are used to work with MRPT so for us is not big deal to depend on MRPT, but i understand that it may not be the case for others.

So yes, make a pull request so we can test it.
Thanks!

@artivis
Copy link
Author

artivis commented Aug 31, 2017

Hi,
I wrote a plugin for rf2o (here) so that it can be used in the laser_odometry package.
Since the plugin depends on the pending PR #6 and #10, the plugin's README points to my fork in the meantime.

@lucbettaieb
Copy link

@JGMonroy Have you considered the PR @artivis made? It's good looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants