Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow listeners passed into runtime.onMessage.addListener to return void #109

Open
namukang opened this issue Nov 24, 2024 · 0 comments
Open

Comments

@namukang
Copy link

Previously, listeners for runtime.onMessage.addListener could return Promise<unknown> | true | void:

) => Promise<unknown> | true | void

Currently, they require a return value of Promise<unknown> | true | undefined:

) => Promise<unknown> | true | undefined

Commit where change was made: 85437fc

I believe the correct type should be void rather than undefined so that listeners can return without having to specify undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant