Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore testing against lowest allowed versions of dependencies #481

Open
deviantintegral opened this issue Mar 15, 2024 · 0 comments
Open

Restore testing against lowest allowed versions of dependencies #481

deviantintegral opened this issue Mar 15, 2024 · 0 comments
Labels
dependencies Changes required to keep up to date with upstream software

Comments

@deviantintegral
Copy link
Member

https://github.com/Lullabot/drainpipe/pull/438/files#diff-be05ff14f4265b6230c383cccc43081eb4dde30ac15ce0e6021de115982724e6L14-L17 removed --prefer-lowest from the test job working with the oldest version of PHP. This allowed us to ensure that transitive dependencies that may be locked to older versions on real-world sites still function, and that we don't accidentally use APIs from newer releases without declaring or updating the dependency.

Let's restore this to our tests.
@deviantintegral deviantintegral added the dependencies Changes required to keep up to date with upstream software label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Changes required to keep up to date with upstream software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deviantintegral