Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for LRC format lyrics embedded in metadata #235

Open
1 of 2 tasks
imgradeone opened this issue Jan 13, 2025 · 3 comments
Open
1 of 2 tasks
Labels
R - enhancement New feature or request

Comments

@imgradeone
Copy link

imgradeone commented Jan 13, 2025

Eligibility

  • I confirm that I am a genuine user and have purchased the software.
  • Alternatively, I have paid for this feature request on Issue Hunt.

image

Feature Description

Describe the feature you'd like to request:

  • Added support for LRC format lyrics in the "Lyrics" view if a song has LRC format lyrics in its metadata. (External LRC files could be considered as well. External LRC files are actually supported.)

Use Case

Explain the use case for this feature:

  • Lyrics in LRC format are widely used in digital media management. LRC format is simple to read, edit and use.
  • I have already added lyrics in LRC format to metadata of some of my local music files, and players like Poweramp and AIMP can display the lyrics correctly. Somehow I prefer to embed LRC lyrics in metadata for ease of use.

Expected Benefits

  • Currently Rune (as of version 1.1.0) only supports SRT format lyrics. Support for lyrics in LRC format will improve Rune's functionality and compatibility with other music management and playback methods.
  • Reading LRC lyrics from metadata can provide an easier experience for people who prefer to include LRC lyrics in metadata.
@dosubot dosubot bot added the R - enhancement New feature or request label Jan 13, 2025
@Losses
Copy link
Owner

Losses commented Jan 13, 2025

It's already implemented in v1.1, and will be deployed recently, please checkout the release note:

https://github.com/Losses/rune/releases/tag/v1.1.0

@imgradeone imgradeone changed the title [Feature Request] Support fot LRC format lyrics [Feature Request] Support for LRC format lyrics embedded in metadata Jan 13, 2025
@imgradeone
Copy link
Author

Sorry for my clerical error and misunderstanding. I now know that external LRC lyrics are supported, but as of version 1.1.0, LRC lyrics embedded in metadata are still not yet usable, so I have updated the feature request.

@Losses
Copy link
Owner

Losses commented Jan 13, 2025

Thank you for your suggestion. I will address this request in version 2.0. Considering there might be many different lyrics formats, I'll need to find a way to distinguish which format the embedded lyrics belong to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R - enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants