Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Support EIP1271 #69

Open
rodrigoherrerai opened this issue Aug 17, 2022 · 5 comments
Open

Support EIP1271 #69

rodrigoherrerai opened this issue Aug 17, 2022 · 5 comments

Comments

@rodrigoherrerai
Copy link

Is your feature request related to a problem? Please describe.
Looks Rare's UI does not support EIP1271. It makes the usage of smart contract wallets impossible for certain operations e.g making an offer.

Describe the solution you'd like
Support EIP1271, it is pretty simple.

Describe alternatives you've considered

Additional context

@treasureseth
Copy link

Is there an API endpoint for listing via EIP 1271? Doesn't have to be a UI

@rodrigoherrerai
Copy link
Author

You just need to check if the address has code, if it does:

  1. Call 'isValidSignature()' with the hash and the signature.

If it returns the magic value, then the signature is correct.

The problem with not supporting this, is that wallets like gnosis and argent are unusable.

@treasureseth
Copy link

I know how to make the contract work. But to list it, you still need an API endpoint. That was what I was referring to

@rodrigoherrerai
Copy link
Author

I don't understand, what do you mean by "list it" ?

The checks and auth should be done from the UI.

@treasureseth
Copy link

Just by creating the contract, you won't create a listing. You need to pass on the signature to LooksRare so that they can save it to their database. That is done by either an API call or by the UI.

That's why I was asking if there's an API endpoint to list it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants