Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcc_cyclos_base] inactive account can be selected and problem can rise #246

Open
vaab opened this issue Aug 18, 2022 · 0 comments
Open

Comments

@vaab
Copy link
Collaborator

vaab commented Aug 18, 2022

In the following code:

https://github.com/Lokavaluto/lokavaluto-addons/blob/12.0/lcc_cyclos_base/models/res_partner.py#L33

The function to get one cyclos account, doesn't check for status value, and could check for that.
Why not check for multiple account and clearly fail early if more than one ?
What is the cost of actually support multiple account ?

A bug emerged from this code in a special scenario where 2 accounts where available but only one was active, the inactive one was selected by the given function, and unrelated errors occured (the wrong account was forcePasswordUpdate)... etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant