-
Notifications
You must be signed in to change notification settings - Fork 181
New reader #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hirogen
wants to merge
29
commits into
Development
Choose a base branch
from
new_reader
base: Development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New reader #506
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
4793787
replace fixed regex with regex properties and regex attributes
Hirogen 039b19b
Merge branch 'Development' into performance_optimizations
ffa5ecc
optimization, added ISpan stuff
f54bcc4
pipelines docs for implementation
76a42f2
Pipeline added
Hirogen 02108cd
Merge branch 'Development' into new_reader
2fbc998
pipelines update
90ef20b
locks
5040622
update reader
ea35028
chore: update plugin hashes [skip ci]
github-actions[bot] cceaa03
Update src/ColumnizerLib/ILogLineSpanColumnizer.cs
Hirogen a2e43ff
Update src/LogExpert.Core/Interface/ILogStreamReaderSpan.cs
Hirogen 0765822
Update src/LogExpert.UI/Controls/LogWindow/LogWindow.cs
Hirogen a76efa0
Update src/LogExpert.Core/Interface/ILogStreamReaderSpan.cs
Hirogen 91f5c30
Update src/LogExpert.Core/Classes/Log/LogBuffer.cs
Hirogen f846922
chore: update plugin hashes [skip ci]
github-actions[bot] 97808ba
Update src/ColumnizerLib/ITextValue.cs
Hirogen 433ba41
Update src/ColumnizerLib/ILogLine.cs
Hirogen 6a3b31d
review comments
Hirogen 262fab1
chore: update plugin hashes [skip ci]
github-actions[bot] f163dab
benchmakr summary
a039252
Merge branch 'new_reader' of https://github.com/LogExperts/LogExpert …
b28a006
chore: update plugin hashes [skip ci]
github-actions[bot] 3f8dde4
benchmark md updates
Hirogen 0a2f759
Merge branch 'new_reader' of https://github.com/LogExperts/LogExpert …
Hirogen 33fa73e
chore: update plugin hashes [skip ci]
github-actions[bot] 7051b8d
update
Hirogen 316370d
update new line search
Hirogen 3db95b1
more changes
Hirogen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| namespace ColumnizerLib; | ||
|
|
||
| public interface ILogLineMemory : ILogLine | ||
| { | ||
| ReadOnlyMemory<char> FullLineMemory { get; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| public interface ILogLineSpan | ||
| { | ||
| ReadOnlySpan<char> GetFullLineSpan (); | ||
|
|
||
| int LineNumber { get; } | ||
| } | ||
|
|
||
| public readonly ref struct LogLineSpan : ILogLineSpan | ||
Hirogen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| private readonly ReadOnlyMemory<char> _lineMemory; | ||
|
|
||
| public LogLineSpan (ReadOnlyMemory<char> lineMemory, int lineNumber) | ||
| { | ||
| _lineMemory = lineMemory; | ||
| LineNumber = lineNumber; | ||
| } | ||
|
|
||
| public static LogLineSpan Create (ReadOnlyMemory<char> lineMemory, int lineNumber) => new LogLineSpan(lineMemory, lineNumber); | ||
|
|
||
| public ReadOnlySpan<char> GetFullLineSpan () => _lineMemory.Span; | ||
|
|
||
| public int LineNumber { get; } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| namespace ColumnizerLib; | ||
|
|
||
| public interface ILogLineSpanColumnizer : ILogLineColumnizer | ||
| { | ||
| /// <summary> | ||
| /// Span-based version of SplitLine that avoids string allocations | ||
| /// </summary> | ||
| IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ReadOnlySpan<char> lineSpan, int lineNumber); | ||
|
|
||
| /// <summary> | ||
| /// Span-based timestamp extraction | ||
| /// </summary> | ||
| DateTime GetTimestamp (ILogLineColumnizerCallback callback, ReadOnlySpan<char> lineSpan, int lineNumber); | ||
|
|
||
| /// <summary> | ||
| /// Indicates if this columnizer supports span-based operations | ||
| /// </summary> | ||
| bool IsSpanSupported { get; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,22 @@ | ||
| namespace ColumnizerLib; | ||
|
|
||
| // DEPRECATED: This interface adds no value and causes performance overhead. | ||
| // Keep for backward compatibility but mark as obsolete. | ||
| [Obsolete("ITextValue is deprecated. Access FullLine or FullValue directly instead.", false)] | ||
| public interface ITextValue | ||
| { | ||
| #region Properties | ||
|
|
||
| string Text { get; } | ||
|
|
||
| #endregion | ||
| } | ||
|
|
||
| public static class TextValueExtensions | ||
| { | ||
| [Obsolete("Use ILogLine.FullLine property directly instead of this extension method")] | ||
| public static string GetText (this ILogLine logLine) => logLine.FullLine; | ||
|
|
||
| [Obsolete("Use DisplayValue property directly")] | ||
| public static string GetText (this IColumn column) => column.DisplayValue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <Project> | ||
| <!-- This file prevents the parent Directory.Build.props from affecting BenchmarkDotNet's generated projects --> | ||
| <PropertyGroup> | ||
| <GenerateAssemblyInfo>true</GenerateAssemblyInfo> | ||
| <SignAssembly>false</SignAssembly> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Do NOT include the shared AssemblyInfo.cs --> | ||
| <ItemGroup> | ||
| <Compile Remove="$(MSBuildThisFileDirectory)..\Solution Items\AssemblyInfo.cs" /> | ||
| <Compile Remove="..\Solution Items\AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Prevent parent Directory.Build.props from being applied --> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" Condition="false" /> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <Project> | ||
| <!-- Prevent parent Directory.Build.targets from being imported --> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <!-- Override Directory.Build.props settings for BenchmarkDotNet compatibility --> | ||
| <GenerateAssemblyInfo>true</GenerateAssemblyInfo> | ||
| <SignAssembly>false</SignAssembly> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\LogExpert.Core\LogExpert.Core.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Exclude the shared AssemblyInfo.cs that Directory.Build.props tries to add --> | ||
| <ItemGroup> | ||
| <Compile Remove="..\Solution Items\AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.