Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix wrong reference to systemd #1374

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Conversation

dwt
Copy link
Contributor

@dwt dwt commented Mar 6, 2025

Darwin has LaunchD.

@dwt
Copy link
Contributor Author

dwt commented Mar 22, 2025

@emilazy I did apply your suggestion - does that resolve your concerns?

@emilazy
Copy link
Member

emilazy commented Mar 22, 2025

Looks good, thanks! Could you squash the commits into one e.g. autossh: fix incorrect reference to systemd?

The next “service” should probably be changed to “daemon” too. (Sorry for missing that…)

@dwt
Copy link
Contributor Author

dwt commented Mar 23, 2025

@emilazy I took the liberty to also update the formatting to nixpkgs current standard. Hope that's ok.

@emilazy
Copy link
Member

emilazy commented Mar 23, 2025

Thanks! We’re waiting on NixOS/nixpkgs#380990 to do a treewide reformat as the commits need to go in .git-blame-ignore-revs to not mess up git blame and keeping in line with NixOS formatting makes backports easier. Would you mind dropping the reformatting commit for now? We’ll be doing a mass reformat around the time we move to the new repo.

@dwt
Copy link
Contributor Author

dwt commented Mar 23, 2025

@emilazy Here you go

@dwt
Copy link
Contributor Author

dwt commented Mar 23, 2025

When you're on in to change tall the things, maybe even renaming master to main could be on the table…

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I’ve actually thought that we might want to rename the main branch to nix-darwin-unstable, to extend the nix-darwin-24.11nixpkgs-24.11-darwin release branch correspondence we have. Not sure if that would be too weird though…

@emilazy emilazy merged commit ebb88c3 into nix-darwin:master Mar 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants