Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat):Enhanced language detection #1

Closed
sudoskys opened this issue Jan 26, 2024 · 3 comments
Closed

(feat):Enhanced language detection #1

sudoskys opened this issue Jan 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sudoskys
Copy link
Member

with https://github.com/aboSamoor/pycld2

checkout Mimino666/langdetect#51 (comment)

@sudoskys sudoskys added the enhancement New feature or request label Jan 26, 2024
@sudoskys
Copy link
Member Author

sudoskys commented Jul 6, 2024

pycld aboSamoor/pycld2#60 cant build wheel

@sudoskys
Copy link
Member Author

sudoskys commented Jul 6, 2024

After evaluation, this work will no longer be continued.

@sudoskys sudoskys closed this as completed Jul 6, 2024
Copy link

neutron-nerve bot commented Jul 6, 2024

Enhanced Language Detection Issue Report

Issue Summary

  • Title: (feat): Enhanced language detection
  • Created by: @sudoskys
  • Created on: 2024-01-26
  • Closed by: @sudoskys
  • Closed on: 2024-07-06

Description

The issue proposed the integration of enhanced language detection capabilities using the PyCLD2 library, as referenced in the aboSamoor/pycld2 repository. This enhancement was suggested to improve language identification accuracy and speed for the LlmKira/fast-langdetect project.

Key Events & Discussion

  1. Initial Proposal:

    • A proposal was made to integrate the PyCLD2 library into the project for enhanced language detection, inspired by a recommendation on the Mimino666/langdetect issue.
  2. Build Challenges:

    • An issue related to building the PyCLD2 wheel was highlighted by @sudoskys in the following comment:
      pycld https://github.com/aboSamoor/pycld2/issues/60 cant build wheel
      
  3. Evaluation Outcome:

    • After thorough evaluation and attempts to overcome the build challenges, the contributor @sudoskys concluded that the integration of PyCLD2 would not proceed further:
      After evaluation, this work will no longer be continued.
      

Final Outcome

Due to unresolved issues with building the PyCLD2 wheel, and subsequent evaluation determining that further progress was not feasible, the proposed enhancement for integrating PyCLD2 was formally closed.

Conclusion

The initiative to enhance language detection using PyCLD2 has been reviewed and ultimately concluded without implementation due to technical difficulties. The project will continue to seek other viable solutions for improving language identification.

Acknowledgment

We extend our gratitude to @sudoskys for the proposal and diligent evaluation of the potential enhancement.


This report consolidates the details of the now closed issue to provide a clear and concise summary for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant