Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments have HTML in them #389

Closed
matt-ewan-laws opened this issue May 22, 2024 · 7 comments · Fixed by #390
Closed

Comments have HTML in them #389

matt-ewan-laws opened this issue May 22, 2024 · 7 comments · Fixed by #390
Assignees
@Livinglist
Labels
bug Something isn't working

Comments

@matt-ewan-laws
Copy link

Screenshot_2024-05-22-07-32-34-04_a4cc5d72270e66b9bb8cebf0fde3bfdf

Android 13
@Livinglist
Copy link
Owner

Thanks for letting me know, I think Hacker News just updated their HTML.

@Livinglist Livinglist self-assigned this May 22, 2024
@Livinglist Livinglist added the bug Something isn't working label May 22, 2024
@Livinglist Livinglist linked a pull request May 22, 2024 that will close this issue
fix comment text parsing. #390
Merged
@Livinglist Livinglist pinned this issue May 22, 2024
@Livinglist
Copy link
Owner

keeping this issue open until the fix is out.

@Livinglist Livinglist reopened this May 22, 2024
@Livinglist
Copy link
Owner

142 (2.7.3) has been uploaded to Google Play Store for review. It's gonna take a while before the build with fix is released on F-Droid, but see here if you can't wait: https://github.com/Livinglist/Hacki/releases/tag/v2.7.3

@matt-ewan-laws
Copy link
Author

Thanks for letting me know, I think Hacker News just updated their HTML.

Cheers for the great work

@matt-ewan-laws
Copy link
Author

It's still showing in some posts.

Screenshot_2024-05-22-18-30-23-60_a4cc5d72270e66b9bb8cebf0fde3bfdf.jpg

@Livinglist
Copy link
Owner

Livinglist commented May 22, 2024 •
edited
Loading

It's still showing in some posts.

Hi, @matt-ewan-laws can you try clearing cache in the settings, and confirm you are on v2.7.3 by tapping on “About”.
IMG_2784

@matt-ewan-laws
Copy link
Author

It's still showing in some posts.

Hi, @matt-ewan-laws can you try clearing cache in the settings, and confirm you are on v2.7.3 by tapping on “About”. IMG_2784

Yes I was being a dummy and didn't realise my attempt to install the latest had failed.

Uninstalled previous version, installed newest apk and everything appears working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Livinglist Livinglist

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix comment text parsing. Livinglist/Hacki
2 participants
@Livinglist @matt-ewan-laws