Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of Module:Standings in Module:TournamentStructure #5467

Open
hjpalpha opened this issue Feb 20, 2025 · 1 comment
Open

Make use of Module:Standings in Module:TournamentStructure #5467

hjpalpha opened this issue Feb 20, 2025 · 1 comment
Labels
c: standard chore

Comments

@hjpalpha
Copy link
Collaborator

Make use of Module:Standings in Module:TournamentStructure when fetching the standings/standingsEntries
@hjpalpha hjpalpha mentioned this issue Feb 20, 2025
Merged
@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Mar 4, 2025

issues with doing so:

  • filtering in Module:TournamentStructure is different from what Module:Standings uses
  • Module:Standings only returns 1 instead of all applicable standingstables
  • Module:Standings doesn't support queries in non main space
  • Module:Standings fetches all rounds even if only the last round is needed for Module:TournamentStructure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: standard chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjpalpha