Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider kicking Opponent.toMode and Opponent.toLegacyMode from Module:Opponent #4641

Open
5 tasks
hjpalpha opened this issue Aug 25, 2024 · 0 comments
Open
5 tasks

Consider kicking Opponent.toMode and Opponent.toLegacyMode from Module:Opponent #4641

hjpalpha opened this issue Aug 25, 2024 · 0 comments
Labels
c: opponent

Comments

@hjpalpha
Copy link
Collaborator

hjpalpha commented Aug 25, 2024 •
edited
Loading

  • odly wiki specific commons functions
  • from the few wikis that still use them most are moving away from it or at least from usig those functions anyways (especially easy with MGI refactor)
  • longterm all consumers should move away from using mode towards moving opponenttype anyways

usages for toMode

  • easportsfc (fifa) MGI
  • tetris MGI
  • magic MGI
  • goals MGI (not on git, not even as PR ...)

usages of toLegacyMode

  • aoe MGI

usages determined by insource searches via https://tools.liquipedia.space/?view=search
not listing any dev nor archived modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: opponent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjpalpha