Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error handling for file input #9

Open
5 tasks
talolard opened this issue Jul 7, 2019 · 0 comments
Open
5 tasks

Add Error handling for file input #9

talolard opened this issue Jul 7, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@talolard
Copy link
Collaborator

talolard commented Jul 7, 2019

Currently we support adding files but there is no error handling. Things to handle

  • Restrict file types to JSON CSV and TSV
  • Display error message when there is an error parsing the JSON (e.g it is invalid)
  • Display an error message when the JSON is not supported (we expect a JSON array of objects)
  • Warn about CSV parsing errors from papa parse
  • Prevent the app from crashing when there is an error (currently there is no error handling at all)

Relevnt file is https://github.com/LightTag/ylabel/blob/master/src/data/components/input/fileInput.js

@talolard talolard added the good first issue Good for newcomers label Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant