Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Process doesn't exit on SIGTERM | SIGINT #95

Open
cirocosta opened this issue Aug 16, 2017 · 0 comments
Open

Process doesn't exit on SIGTERM | SIGINT #95

cirocosta opened this issue Aug 16, 2017 · 0 comments

Comments

@cirocosta
Copy link
Contributor

Hey,

I noticed that if I send a signal to the process it doesn't get finalized, even though the server gets stopped. It turns our that this behavior happens due to magnet.stop() not stopping the execution of the process after stopping the server:

https://github.com/wedeploy/magnet/blob/d157bbfb3f20aaaa4dfa9c1fd05fc8e12df1e47c/src/bin/magnet-start#L38-L45

I'd say the fix would be to add a process.exit(0) after magnet.stop().

Is there anything I'm missing?

Thx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants