From 077deb1067cbe534e19c9a0e57565a9f4de991d9 Mon Sep 17 00:00:00 2001
From: ctw-joao-luis <joao.miguel.luis@criticaltechworks.com>
Date: Fri, 27 Sep 2024 11:54:37 +0100
Subject: [PATCH] Update xmlrpc to lichtblick/xmlrpc (#198)

**User-Facing Changes**
N/A

**Description**
Update on package.json to @lichtblick/xmlrpc dependency

<!-- link relevant GitHub issues -->
<!-- add `docs` label if this PR requires documentation updates -->
<!-- add relevant metric tracking for experimental / new features -->

**Checklist**

- [X] The web version was tested and it is running ok
- [X] The desktop version was tested and it is running ok
- [ ] This change is covered by unit tests
---
 packages/suite-base/package.json              |  2 +-
 packages/suite-base/src/players/Ros1Player.ts |  2 +-
 yarn.lock                                     | 16 ++++++++++++++--
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/packages/suite-base/package.json b/packages/suite-base/package.json
index b66caeb531..938176a7c7 100644
--- a/packages/suite-base/package.json
+++ b/packages/suite-base/package.json
@@ -27,7 +27,6 @@
     "@foxglove/theme": "workspace:*",
     "@foxglove/typescript-transformers": "workspace:*",
     "@foxglove/ws-protocol": "0.7.2",
-    "@foxglove/xmlrpc": "1.3.0",
     "@lichtblick/avl": "1.0.0",
     "@lichtblick/chartjs-plugin-zoom": "1.0.0",
     "@lichtblick/comlink-transfer-handlers": "workspace:*",
@@ -52,6 +51,7 @@
     "@lichtblick/velodyne-cloud": "1.0.0",
     "@lichtblick/wasm-bz2": "1.0.0",
     "@lichtblick/wasm-lz4": "1.0.0",
+    "@lichtblick/xmlrpc": "1.0.0",
     "@mcap/core": "2.0.2",
     "@mui/icons-material": "5.15.5",
     "@mui/material": "5.13.5",
diff --git a/packages/suite-base/src/players/Ros1Player.ts b/packages/suite-base/src/players/Ros1Player.ts
index 512e32b226..c7164af9c2 100644
--- a/packages/suite-base/src/players/Ros1Player.ts
+++ b/packages/suite-base/src/players/Ros1Player.ts
@@ -6,7 +6,6 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/
 
 import { RosNode, TcpSocket } from "@foxglove/ros1";
-import { HttpServer } from "@foxglove/xmlrpc";
 import * as _ from "lodash-es";
 import { v4 as uuidv4 } from "uuid";
 
@@ -35,6 +34,7 @@ import {
 } from "@lichtblick/suite-base/players/types";
 import { RosDatatypes } from "@lichtblick/suite-base/types/RosDatatypes";
 import rosDatatypesToMessageDefinition from "@lichtblick/suite-base/util/rosDatatypesToMessageDefinition";
+import { HttpServer } from "@lichtblick/xmlrpc";
 
 const log = Logger.getLogger(__filename);
 const rosLog = Logger.getLogger("ROS1");
diff --git a/yarn.lock b/yarn.lock
index 49b543720f..1e43f78b2b 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2611,7 +2611,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@foxglove/xmlrpc@npm:1.3.0, @foxglove/xmlrpc@npm:^1.3.0":
+"@foxglove/xmlrpc@npm:^1.3.0":
   version: 1.3.0
   resolution: "@foxglove/xmlrpc@npm:1.3.0"
   dependencies:
@@ -3342,7 +3342,6 @@ __metadata:
     "@foxglove/theme": "workspace:*"
     "@foxglove/typescript-transformers": "workspace:*"
     "@foxglove/ws-protocol": 0.7.2
-    "@foxglove/xmlrpc": 1.3.0
     "@lichtblick/avl": 1.0.0
     "@lichtblick/chartjs-plugin-zoom": 1.0.0
     "@lichtblick/comlink-transfer-handlers": "workspace:*"
@@ -3367,6 +3366,7 @@ __metadata:
     "@lichtblick/velodyne-cloud": 1.0.0
     "@lichtblick/wasm-bz2": 1.0.0
     "@lichtblick/wasm-lz4": 1.0.0
+    "@lichtblick/xmlrpc": 1.0.0
     "@mcap/core": 2.0.2
     "@mui/icons-material": 5.15.5
     "@mui/material": 5.13.5
@@ -3643,6 +3643,18 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@lichtblick/xmlrpc@npm:1.0.0":
+  version: 1.0.0
+  resolution: "@lichtblick/xmlrpc@npm:1.0.0"
+  dependencies:
+    "@foxglove/just-fetch": ^1.2.4
+    byte-base64: ^1.1.0
+    sax: ^1.2.4
+    xmlbuilder2: ^3.0.2
+  checksum: 4aaf5c2f1b0f8778e735fe6f244099b81c1a0360040158cc019d72ecb01ce8679e893141cd51f2a8492e2cccbde76c404a914d3d9f69b4fa71b9a3ffa6f0be25
+  languageName: node
+  linkType: hard
+
 "@malept/cross-spawn-promise@npm:^1.1.0":
   version: 1.1.1
   resolution: "@malept/cross-spawn-promise@npm:1.1.1"