Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status to LibreSign document at app Files #4160

Open
Extarys opened this issue Dec 16, 2024 · 4 comments
Open

Add status to LibreSign document at app Files #4160

Extarys opened this issue Dec 16, 2024 · 4 comments
Labels
feature-request New feature request

Comments

@Extarys
Copy link

Extarys commented Dec 16, 2024

Is your feature request related to a problem? Please describe.
I created a test PDF Test signature.pdf for the admin to sign, once signed, a new file Test signature.signed.pdf was created.
But now I have two files: Test signature.pdf and Test signature.signed.pdf and both shows LibreSign panel on the right saying the admin signed it.

image

If I removed the "signed" from the name, there is no way to show which document was signed precisely. Yes I can check the file size, but I should not have to.

Describe the solution you'd like

  • Show something near the file icon to show that this file contains a digital signature from Libresign (this might be nextcloud upstream to show that the file contain a digital signature ?)
  • Update the sidebar
    • For the original document: Show who requested the signature of that document and if/when it was signed
    • For the signed document: Show the digital signature/metadata of that file + what's above (For the original document) Clearly state that this document is the one containing a signature.

It would also be nice to have more instructions like : once signed, the original document can be safely deleted if not needed.
Also, a text for the modal when we can create signature boxes to explain how it works (or a ? icon). I didn't know and found out while looking at issues here.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@vitormattos
Copy link
Member

Hi @Extarys,

Thanks a lot by your considerations. Follow my points about your considerations.

Add status to LibreSign documents

Maybe this issue could be renamed to this title and go ahead with this discussion. Could you rename this issue to this (Add status to LibreSign documents)?

If I removed the "signed" from the name, there is no way to show which document was signed precisely. Yes I can check the file size, but I should not have to.

The signed document is the document that have the suffix: signed.pdf. And yes, if you rename this, don't will be possible identify by a easy way if this document was signed or not.

Show something near the file icon to show that this file contains a digital signature from Libresign (this might be nextcloud upstream to show that the file contain a digital signature ?)

We can put an icon together of file icon but what kind of icon could represent that this document was digitally signed? Other question to think about is that LibreSign have other status and will we also use this? Follow below a screenshot of status list of LibreSign took from filter of LibreSign (go to LibreSign, Files and will be possible see the filters):

Screenshot_20241217_104948

We have a problem to think how we will solve. Now, if have more than a signer, after the first signature will be created the document signed.pdf and my question is: what will be the file that will have the status, the signed document or the original document? Will we have a status or icon at original document?

The follow example is a screenshot of Approval app, that use a green, and checked icon to identify that the file was approved, red when wasn't approved and gray when started the approval flow and is waiting for a final status:

Screenshot_20241217_113652

Show who requested the signature of that document

Show who requested the signature of that document

This could be part of the follow issue:

Would be good to have more contributions at the issue #4070 with your suggestions or maybe into a new issue specific to the right sidebar because the issue #4070 is about the moment that a signer open the document to sign and isn't about the right sidebar.

I think that this is is unrelated to this current issue.

Show the digital signature/metadata of that file

if/when it was signed

For the signed document: Show the digital signature/metadata of that file

This information is available at validation page. When all signers finish the sign flow, the validate button will be visible and you can see the validation screen. We already have an issue with improvement suggestions to put at validation screen here:

If you have any idea related to this issue, would be good have your contribution at #2616

Safely deleted the original document after we have a signed document

once signed, the original document can be safely deleted if not needed.

This is a good feature. Now the original document is associated to the signed document by a database relation and we have logic flows that is associated to this and I think that the main is that now, when delete the original document we delete the signed document. Other very important flow that I think that will be the most hard to change is because the UUID to validate the document is an attribute of original file and not of signed file and have a lot of side effects to change this. Will be necessary change these flows.

We also need to think what's the best moment to allow to delete the original document. Now, the document .signed is created when the first signer sign the document. Thinking at scenario that we have 3 signers, always that a signer see the document to sign, is displayed the original document and not the document with the signature of previous signers. To remove the association from original document and signed document, will be necessary change this and show, by example, to 2th signer the version with the signature of 1th signer and the 3th signer will see the document already signed by the 1th and 2th signer. This is a good point of improvement, but we need to think if have security impacts.

Could you create a new issue specific to this? I think that this could be described at a new issue.

User and admin documentation

Also, a text for the modal when we can create signature boxes to explain how it works (or a ? icon). I didn't know and found out while looking at issues here.

This is more as a documentation and we are thinking about how to implement a good user and admin documentation. We wish to put the documentation inside our site. Yes, we haven't now any issue about documentation of LibreSign and also would be good to have a specific issue to this.


Note

An important point is that LibreSign is maintained by funding of peoples that love this project. If you wish to help us to implement these changes, another good way is sponsoring this project. And if you prefer help by other way or a more formal way, don't worry, you can send us an email to talk about: contact [at] libresign.coop

@Extarys Extarys changed the title Clear confusion between signed and unsigned file Add status to LibreSign document Dec 17, 2024
@Extarys
Copy link
Author

Extarys commented Dec 18, 2024

Wow! Thanks for your detailed reply! I'll attack a small part today and revisit tomorrow.

I didn't think I threw so much stuff in there - and I was careful to not say every suggestion I had 😂

Icons

We have a problem to think how we will solve. Now, if have more than a signer, after the first signature will be created the document signed.pdf and my question is: what will be the file that will have the status, the signed document or the original document? Will we have a status or icon at original document?

I'll throw some ideas here so we can work on this and brainstorm a bit.

Original document:

  • The original.pdf was signed somewhere, somehow, some time ago:
    image

The sidebar would give us all the details. (See other issue below)

.signed.pdf contain all signatures:

Imitate a "seal"
image
or simpler ?
image

.signed.pdf contain some signature (not all parties signed it yet):

image

Show who requested the signature of that document

Created #4164

Safely deleted the original document after we have a signed document

Created #4165

@vitormattos vitormattos changed the title Add status to LibreSign document Add status to LibreSign document at app Files Dec 18, 2024
@vitormattos
Copy link
Member

I renamed this issue to be more specific and clear. Could you check if the new name is OK?

@vitormattos
Copy link
Member

About the icons, I removed the customized icons from LibreSign and replaced by Matherial Design Icons:

https://pictogrammers.com/library/mdi/

Other point to consider, we need to think how this will be at file list in a grid and list type of files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
Status: 0. Needs triage
Development

No branches or pull requests

2 participants