Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasyHack: Can't pass custom bootstrap CLI arguments anymore #13

Open
xbubli opened this issue Aug 10, 2016 · 0 comments
Open

EasyHack: Can't pass custom bootstrap CLI arguments anymore #13

xbubli opened this issue Aug 10, 2016 · 0 comments

Comments

@xbubli
Copy link
Collaborator

xbubli commented Aug 10, 2016

This is a regression in noa-libre 3.0.

Older versions of noa-libre used to come with bootstrapsocketconnector ( jar w/ couple of methods for creating a socket connection to *Office), which allowed passing custom command line arguments to bootstrapped instance of *Office.

bootstrapsocketconnector has been replaced by functionality from Libreoffice core javaunohelper Bootstrap class, however the ability to pass custom arguments has been lost in the process.

This task is about restoring the feature. See this and this commit and the code removed therein for where to start.

In LocalOfficeConnectionGhost class, if officeArguments member variable is non-null and non-empty, you will need to call the overloaded version of bootstrap method (from com.sun.star.comp.helper.Bootstrap class), the one that takes the array of strings as an argument

In IOfficeApplication class, I'd be nice to comment/document how the users can set their APPLICATION_ARGUMENTS_KEY variable (i.e. that they have to use getDefaultOptions method from com.sun.star.comp.helper.Boostrap class, add/remove options from its return value and then convert it back to array of strings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant