Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall-based? #42

Open
gp-Airee opened this issue Sep 23, 2019 · 12 comments
Open

Waterfall-based? #42

gp-Airee opened this issue Sep 23, 2019 · 12 comments

Comments

@gp-Airee
Copy link

Could these changes be made against Waterfall or maybe done via patches so it can be applied among other modifications of Bungee?

@DokanBoy
Copy link

DokanBoy commented Jan 9, 2020

Why not do it? @Leymooo

@Leymooo
Copy link
Owner

Leymooo commented Jan 9, 2020

I will rewrite botfilter, because for now it has an old code base which is bad, this is why i do not rebase BF to waterfall. There is no eta when i will start rewrite, but I will try not to delay for too long a period.

@DokanBoy
Copy link

DokanBoy commented Jan 9, 2020

Ну давай, ждем-с. А когда будешь переписывать, на WF тоже не планируешь основывать?

@Leymooo
Copy link
Owner

Leymooo commented Jan 9, 2020

Планирую.

@gp-Airee
Copy link
Author

Thank you. Also worth noting that waterfall uses a patch system to add their patches, perhaps botfilter can be done this way?

Спасибо. Также стоит отметить, что водопад использует систему патчей для добавления своих патчей, возможно, это можно сделать с помощью botfilter?

@y6x2digc
Copy link

just download this diff https://github.com/SpigotMC/BungeeCord/compare/master...Leymooo:master.diff and apply it to Waterfall

@gp-Airee
Copy link
Author

gp-Airee commented Jul 26, 2020 via email

@y6x2digc
Copy link

@gp-Airee

$ wget -O a.diff https://github.com/SpigotMC/BungeeCord/compare/master...Leymooo:master.diff
$ cd [Waterfall's dir]
$ patch -p1 < [path to a.diff]

and solve conflicts

@y6x2digc
Copy link

@Leymooo I don’t think the code base is that bad

@NoJokeFNA
Copy link

@Leymooo Sup, any news about Waterfall based fork? Have you tried this guy's diff command yet?

@NotPhasmatos
Copy link

Any news?

@NoJokeFNA
Copy link

Yes, Leymooo won't spend any time migrating it to Waterfall based Fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants