Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #52 GlobalExceptionHandler 수정 #52

Closed
hyxklee opened this issue Oct 4, 2024 · 0 comments · Fixed by #58
Closed

Refactor #52 GlobalExceptionHandler 수정 #52

hyxklee opened this issue Oct 4, 2024 · 0 comments · Fixed by #58
Assignees
@hyxklee
Labels
refactor

Comments

@hyxklee
Copy link
Member

hyxklee commented Oct 4, 2024

🚨 무슨 이유로 코드를 바꾸나요?

  • 기존 로직상 예외가 발생했을 때 status를 200으로 반환하고 내부 body에 status code를 반환했는데, 프론트와의 개발 용이성을 위해 status도 예외에 맞게 반환하는 것으로 수정

💭 어떻게 수정할 건가요?

  • GlobalExceptionHandler의 각 핸들러가 반환하는 타입을 ResponseEntity<>()로 감싸 httpStatus를 errorCode로 반환하도록 수정할 계획입니다
@hyxklee hyxklee self-assigned this Oct 4, 2024
@hyxklee hyxklee changed the title Refactor #51 GlobalExceptionHandler 수정 Refactor #52 GlobalExceptionHandler 수정 Oct 4, 2024
@hyxklee hyxklee linked a pull request Oct 24, 2024 that will close this issue
Refactor #58 글로벌 예외 핸들러 수정 및 예외 관리 수정 #58
Merged
5 tasks
huncozyboy added a commit that referenced this issue Oct 24, 2024
@huncozyboy
Merge pull request #58 from Leets-Official/refactor/#52/GlobalExcepti…
59e3f28 
…onHandler-로직수정

Refactor #58 글로벌 예외 핸들러 수정 및 예외 관리 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyxklee hyxklee

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor #58 글로벌 예외 핸들러 수정 및 예외 관리 수정 Leets-Official/Weeth-BE
1 participant
@hyxklee