VG-7268 Tezos explorer migration (#884)

* VG-737 Fix crash on base58 decode with empty string

* Add new TezosLikeBlockchainExplorer & implemet getCurrentBlock

* Implement getTransactions

* Implement getBalance

* Implement isFunded

* update tezos node url

* fix parsing blocks

* remove unused call to getGasPrice

* make tests use tzstats

* fix missing block level

* fix delegate transactions displayed as undelegate

* implement getFees & test

* remove unused getGasPrice

* update isDelegate

* remove unused getTokenBalance

* fix clang format

* fix http client post headers

* update http cache

* fix some clang tidy warnings

* use clang tidy config in github action

* exclude generated files from clang tidy review & disable complexity check for existing over-complex function

* fix clang tidy

* disable clang tidy complexity for existing code

* fix clang tidy

* fix clang format

* use nlohmann_json as submodule to fix nix builds

* fix circleci

* add helping log

* simplify usage of new json parser

fix new parser logic & some review comments

* fix pagination on synchronisation

* fix for macos

* clang format

* Minor changes for code review comments

* refactor common logic

* better json parsing for BigInt

* constify HttpClient.hpp

* clang format

* fix clang tidy

* move function body to cpp file

Author: BertrandD

.circleci/init_submodules.sh

@@ -19,6 +19,7 @@ git submodule update -- toolchains/polly || echo "===========Polly submodule alr
 git submodule update -- core/lib/spdlog || echo "===========spdlog submodule already updated"
 git submodule update -- core/lib/ethash || echo "===========ethash submodule already updated"
 git submodule update -- core/lib/fmt || echo "===========fmt submodule already updated"
+git submodule update -- core/lib/nlohmann_json || echo "===========nlohmann_json submodule already updated"
 git submodule update -- core/test/lib/googletest || echo "===========googletest submodule already updated"
 git submodule update -- core/lib/CRCpp || echo "===========CRCpp submodule already updated"
 git submodule update -- core/test/lib/libuv || echo "===========libuv submodule already updated"

.clang-tidy

@@ -0,0 +1,20 @@
+# Dumped from custom clion config
+# --> https://gist.github.com/ArnaudValensi/0d36639fb84b80ee57d0c3c977deb70e
+---
+Checks: >
+  -*,bugprone-*,
+  cert-dcl21-cpp,cert-dcl50-cpp,cert-env33-c,cert-err34-c,cert-err52-cpp,cert-flp30-c,cert-msc50-cpp,cert-msc51-cpp,
+  cppcoreguidelines-*,-cppcoreguidelines-macro-usage,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-owning-memory,
+  google-build-using-namespace,google-explicit-constructor,google-global-names-in-headers,google-readability-casting,google-runtime-int,google-runtime-operator,
+  hicpp-*,-hicpp-vararg,
+  misc-*,-misc-throw-by-value-catch-by-reference,
+  modernize-*,-modernize-use-trailing-return-type,
+  performance-*,
+  readability-*,-readability-named-parameter,-readability-identifier-length,-readability-implicit-bool-conversion,-readability-convert-member-functions-to-static,-readability-magic-numbers
+CheckOptions:
+  - key: bugprone-argument-comment.StrictMode
+    value: 1
+  - key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
+    value: 1
+...
+

.github/workflows/clang-tidty-review.yml

@@ -19,6 +19,7 @@ jobs:
           apt_packages: libssl-dev
           # Googletest triggers a _lot_ of clang-tidy warnings, so ignore all
           # the unit tests until they're fixed or ignored upstream
-          exclude: "core/test/*"
+          exclude: "core/test/*,core/lib/*,core/test/lib/*,core/src/api/*,core/src/jni/*"
+          config_file: '.clang-tidy'
           # CMake command to run in order to generate compile_commands.json
           cmake_command: cmake . -B build -DSYS_OPENSSL=ON -DOPENSSL_USE_STATIC_LIBS=TRUE -DTARGET_JNI=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=on && cmake --build build --target secp256k1

.gitmodules

@@ -31,3 +31,6 @@
 [submodule "cmake/cmake-scripts"]
 	path = cmake/cmake-scripts
 	url = https://github.com/StableCoder/cmake-scripts
+[submodule "core/lib/nlohmann_json"]
+	path = core/lib/nlohmann_json
+	url = https://github.com/nlohmann/json.git

core/idl/wallet/common/wallet.djinni

@@ -200,7 +200,7 @@ Operation = interface +c {
 }
 
 OperationOrderKey = enum {
-    date; amount; senders; recipients; type; currency_name; fees; block_height;
+    date; amount; senders; recipients; type; currency_name; fees; block_height; time;
 }
 
 #TODO

core/idl/wallet/configuration.djinni

@@ -13,6 +13,7 @@ BlockchainExplorerEngines = interface +c {
     const RIPPLE_NODE: string = "RIPPLE_NODE";
     const TEZOS_NODE: string = "TEZOS_NODE";
     const TZSTATS_API: string = "TZSTATS_API";
+    const TZKT_API: string = "TZKT_API";
 }
 
 # Available API to use with observers.

core/idl/wallet/tezos/tezos_like_wallet.djinni

@@ -154,15 +154,10 @@ TezosLikeAccount = interface +c {
 	getEstimatedGasLimit(address: string, callback: Callback<BigInt>);
 	# Get fees from network
 	getFees(callback: Callback<BigInt>);
-	# Get gas price from network
-	getGasPrice(callback: Callback<BigInt>);
 	# Get originated accounts by current account
 	getOriginatedAccounts(): list<TezosLikeOriginatedAccount>;
 	# Get current delegate
 	getCurrentDelegate(callback: Callback<string>);
-	# Get the balance of the account for a given token
-	# @param tokenAddress Address of the contract
-	getTokenBalance(tokenAddress: string, callback: Callback<BigInt>);
 	# Get the deterministic operation Uid
 	const computeOperationUid(transaction: TezosLikeTransaction): string;
 }
@@ -203,8 +198,9 @@ TezosConfigurationDefaults = interface +c {
     const BCD_API_ENDPOINT: string = "https://api.better-call.dev/v1";
     const TEZOS_DEFAULT_API_ENDPOINT: string = "https://explorers.api.live.ledger.com";
     const TEZOS_DEFAULT_API_VERSION: string = "v3";
-    const TZSTATS_API_ENDPOINT: string = "https://api.tzstats.com/explorer";
-    const TEZOS_DEFAULT_NODE: string = "https://mainnet.tezrpc.me";
+    const TZSTATS_API_ENDPOINT: string = "https://xtz-explorer.api.vault.ledger.com/explorer";
+    const TZKT_API_ENDPOINT: string = "https://api.tzkt.io";
+    const TEZOS_DEFAULT_NODE: string = "https://xtz-node.api.vault.ledger.com";
     const TEZOS_OBSERVER_NODE_ENDPOINT_S3: string = "https://s3.tezos.com";
     const TEZOS_OBSERVER_WS_ENDPOINT_S2: string = "wss://s2.tezos.com";
     const TEZOS_OBSERVER_WS_ENDPOINT_S3: string = "wss://s3.tezos.com";

core/lib/CMakeLists.txt

@@ -54,3 +54,13 @@ add_subdirectory(soci_sqlite3)
 if (PG_SUPPORT)
     add_subdirectory(soci_postgresql)
 endif()
+
+# Typically you don't care so much for a third party library's tests to be
+# run from your own project's code.
+set(JSON_BuildTests OFF CACHE INTERNAL "")
+
+# If you only include this third party in PRIVATE source files, you do not
+# need to install it when your main project gets installed.
+set(JSON_Install OFF CACHE INTERNAL "")
+
+add_subdirectory(nlohmann_json)

core/lib/nlohmann_json

@@ -159,6 +159,8 @@ endif()
 
 target_link_libraries(ledger-core-interface INTERFACE ethash)
 
+target_link_libraries(ledger-core-interface INTERFACE nlohmann_json::nlohmann_json)
+
 target_link_libraries(ledger-core-interface INTERFACE ${SQLITE_LIB})
 
 file(GLOB_RECURSE LEDGER_CORE_HEADERS