Merge pull request #929 from LedgerHQ/develop

Prepare for 1.0.0

Author: gre

.github/ISSUE_TEMPLATE/bug_report.md

@@ -21,3 +21,4 @@ about: Report a bug in Ledger Live Desktop or a regression.
 #### Steps to reproduce the behavior
 
 <!-- explain steps in detail so we can easily reproduce on our side -->
+<!-- Alternatively provide a screenshot / gif -->

.github/ISSUE_TEMPLATE/discussion.md

@@ -0,0 +1,18 @@
+---
+name: 🗣 Start a Discussion
+about: Discuss to propose changes to improve the state of Ledger Live.
+---
+
+#### Ledger Live Version
+
+<!-- Precise your current app version (Settings > About or bottom-left corner on a crash screen) -->
+
+- Ledger Live **version_here**
+
+#### Part of the application to improve
+
+<!-- which part is to improve? e.g. Send > Step 1 -->
+
+#### Description
+
+<!-- Explain precisely what you think should be improved and how you think it should work -->

.github/ISSUE_TEMPLATE/enhancement.md

@@ -0,0 +1,14 @@
+---
+name: ✨ Feature Request
+about: Any feature you find missing in Ledger Live? Discuss to suggest feature requests.
+---
+
+- [ ] I have checked this feature was not yet requested.
+
+#### Part of the application
+
+<!-- what part of the application would be impacted by this feature? -->
+
+#### Description
+
+<!-- Explain precisely what is the feature about -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -4,4 +4,4 @@ about: If you need help using the app, please contact the support at https://sup
 
 ---
 
-<!-- Please prefer using the support for app usage questions, Github issues are only for technical / developer usage -->
+<!-- https://support.ledgerwallet.com/ – Please prefer using the support for app usage questions, Github issues are only for technical / developer usage -->

.github/ISSUE_TEMPLATE/question.md

@@ -1,20 +1,17 @@
-# Ledger Live - Desktop
+# Ledger Live (desktop) [![CircleCI](https://circleci.com/gh/LedgerHQ/ledger-live-desktop.svg?style=svg)](https://circleci.com/gh/LedgerHQ/ledger-live-desktop) [![Crowdin](https://d322cqt584bo4o.cloudfront.net/ledger-wallet/localized.svg)](https://crowdin.com/project/ledger-wallet)
 
-[![CircleCI](https://circleci.com/gh/LedgerHQ/ledger-live-desktop.svg?style=svg)](https://circleci.com/gh/LedgerHQ/ledger-live-desktop)
-[![Crowdin](https://d322cqt584bo4o.cloudfront.net/ledger-wallet/localized.svg)](https://crowdin.com/project/ledger-wallet)
+> Ledger Live is a new generation wallet desktop application providing a unique interface to maintain multiple cryptocurrencies for your Ledger Nano S / Blue. Manage your device, create accounts, receive and send cryptoassets, [...and many more](https://www.ledgerwallet.com/#LINK_TO_ANNOUNCEMENT).
 
-:warning: Disclaimer: this project is under active development. Use at your own risks.
-
-<img src="/static/docs/ledgerLogo.png" width="200"/>
-
-> Ledger Live Desktop is a new generation Ledger Wallet application build with React, Redux and Electron to run natively on the web. The main goal of the app is to provide our users with a single wallet for all crypto currencies supported by our devices. To learn more check out [Ledger](https://www.ledgerwallet.com/?utm_source=redirection&utm_medium=variable)
+<p align="center">
+ <img src="/docs/screenshot.png" width="550"/>
+</p>
 
 ## Architecture
 
-From one side Ledger Desktop app connected to the Blockchain via the in-house written C++ library - LibCore and from the other it communicates to the Ledger Hardware Device to securely sign all transactions.
+Ledger Live is an hybrid desktop application built with Electron, React, Redux, RxJS,.. and highly optimized with [ledger-core](https://github.com/LedgerHQ/lib-ledger-core) C++ library to deal with blockchains (sync, broadcast,..) via [ledger-core-node-bindings](https://github.com/LedgerHQ/lib-ledger-core-node-bindings). It communicates to Ledger hardware wallet devices (Nano S / Blue) to verify address and sign transactions with [ledgerjs](https://github.com/LedgerHQ/ledgerjs). Some logic is shared with [live-common](https://github.com/LedgerHQ/ledger-live-common).
 
 <p align="center">
- <img src="/static/docs/architecture.png" width="550"/>
+ <img src="/docs/architecture.png" width="550"/>
 </p>
 
 ## Setup
@@ -32,23 +29,15 @@ From one side Ledger Desktop app connected to the Blockchain via the in-house wr
 
 ## Install
 
-1.  Clone or fork the repo
-
-```bash
-git clone [email protected]:LedgerHQ/ledger-live-desktop.git
-```
-
-2.  Install dependencies
-
 ```bash
+# install dependencies
 yarn
 ```
 
 ## Run
 
-Launch the app
-
 ```bash
+# launch the app
 yarn start
 ```
 

README.md

@@ -40,8 +40,8 @@
     "@ledgerhq/hw-app-xrp": "^4.13.0",
     "@ledgerhq/hw-transport": "^4.13.0",
     "@ledgerhq/hw-transport-node-hid": "^4.13.0",
-    "@ledgerhq/ledger-core": "2.0.0-rc.3",
-    "@ledgerhq/live-common": "2.31.0",
+    "@ledgerhq/ledger-core": "2.0.0-rc.4",
+    "@ledgerhq/live-common": "^2.32.0",
     "animated": "^0.2.2",
     "async": "^2.6.1",
     "axios": "^0.18.0",

static/docs/architecture.png renamed to docs/architecture.png

@@ -7,6 +7,7 @@ class Track extends PureComponent<{
   onUnmount?: boolean,
   onUpdate?: boolean,
   event: string,
+  mandatory?: boolean,
 }> {
   componentDidMount() {
     if (typeof this.props.event !== 'string') {
@@ -21,8 +22,8 @@ class Track extends PureComponent<{
     if (this.props.onUnmount) this.track()
   }
   track = () => {
-    const { event, onMount, onUnmount, onUpdate, ...properties } = this.props
-    track(event, properties)
+    const { event, onMount, onUnmount, onUpdate, mandatory, ...properties } = this.props
+    track(event, properties, mandatory)
   }
   render() {
     return null