Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio bus output #42

Closed
Loudened opened this issue Jan 26, 2024 · 6 comments
Closed

audio bus output #42

Loudened opened this issue Jan 26, 2024 · 6 comments

Comments

@Loudened
Copy link

This is really awesome. The best CEF attempt so far :)
Is there a way to grab the audio stream from CEF and pipe it through a Godot audio bus, so that we can make it 3d positional?

@Lecrapouille
Copy link
Owner

Lecrapouille commented Jan 26, 2024

@Loudened maybe this commit #31 but since I git rebased the project GitHub failed showing the diff, but the PR did not pass my code review at this epoch lol. Here is the initial commit pixaline@e99d5b1**

@Loudened
Copy link
Author

Ah yes! This looks like exactly what I mean.
Although also looks like it's not compatible with the current branch and no-one has worked on it for some time :(

@Lecrapouille
Copy link
Owner

Lecrapouille commented Jan 28, 2024

It's working I added @pixaline PR but currently, I cannot swap between pure CEF audio and routing audio to Godot. Once one is selected, we cannot swap to second mode.

Edit: ah ok I understand now: if you select one mode, to swap of mode you have to pause/play the html bouton of the page

Lecrapouille added a commit that referenced this issue Jan 28, 2024
Based on PR made by pixaline #31
@Lecrapouille
Copy link
Owner

Lecrapouille commented Jan 28, 2024

@Loudened I committed in branch https://github.com/Lecrapouille/gdcef/tree/dev-audio-routing, demo 2D, tell me if OK for you I'll merge in main branches.

@Lecrapouille
Copy link
Owner

Lecrapouille commented Jan 29, 2024

Oups! in this branch my C++ got a typo inside a "if" and Godot segfault. I will merge routing sound in the godot-4 branch. Updated demos with AudioStreamPlayer2D and AudioStreamPlayer3D respectively

Lecrapouille added a commit that referenced this issue Jan 29, 2024
Update 2d with AudioStreamPlayer2D and 3d demos with AudioStreamPlayer3D
Lecrapouille added a commit that referenced this issue Jan 29, 2024
Update 2d with AudioStreamPlayer2D and 3d demos with AudioStreamPlayer3D
@Loudened
Copy link
Author

Loudened commented Feb 1, 2024

Thank you @Lecrapouille

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants