Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support 'Torches' in official Old-School Essentials Advanced Fantasy module, out of the box #53

Open
Feldherren opened this issue Jun 29, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Feldherren
Copy link

I suspect it's because instead of the item being 'Torch', OSE's new Advanced Fantasy paid module calls them 'Torches' and gives you a stack of six. Renaming the item to 'Torch' makes it function.

@lupestro
Copy link
Collaborator

Thanks for the heads up. Perhaps you can help me here. I'll attribute any help you offer.

Since I don't own a license to the modules, can you give me the precise text of the item names for the torch and lantern, so that I can make Torch work for these out of the box? Is it just "Torches" or is it something like "Torch, each", as DCC does.

Are there any other light sources that should be included? Can you supply the precise text of their names and their radii, angles, etc.? (Even better yet, drop the light source json for them as a reply to this issue.)

@Feldherren
Copy link
Author

The exact text of the names in the OSE Foundry module are:
Lantern
Torches (6)

There's also a weapon called 'Torch', but I think that's being picked up properly.

I've checked for other items that output light. These three following ones (the swords, anyway) would probably be reasonable to include:

Sword +1, Flaming: casts light in 30ft radius
Sword+1, Light: casts light in 30ft radius
Gem of Brightness: 'beam of pale light, 10ft long and 2ft wide' (this one may be a pain to do)

There are a few more but I'm not sure you'd want to implement them; they're magic items with charges and I don't know how your module handles picking between different light sources. For the sake of completeness, however:

Candle of Invocation: no radii given, unfortunately; other DnD retroclone systems give generic candles as 5ft, though. I assume 360 degrees
Rod of Lordly Might: can act as a Flaming Sword +1, casting light in a 30ft radius
Wand of Radiance: for the one we'd want to enable and disable, 15ft radius

All of these (bar Gem of Brightness) are likely 360 degrees.

@lupestro
Copy link
Collaborator

lupestro commented Aug 12, 2023

So I've got the change from Torch to Torches in for the release I hope to drop today.
Other items:

  • Picking between items is handled by a simple right click on the torch button - it pops a column of buttons under it as a context menu.
  • The inventory tracking tracks quantity on consumable items but doesn't carry a mechanic to track charges on magic items as yet.
  • With this release, we are supplying a set of APIs that macros can call, so Torch could be invoked to do the lighting piece within somebody's macro that does the rest of the system-specific bookkeeping. That would make it viable to use with a custom JSON supplied by the developer of the macros but probably wouldn't be something we would ship out of the box.
  • The glowey swords seem feasible, but they'd need appropriate light stats - I'll leave that to someone who plays the game.
  • We can support the Gem of Brightness by using an 11 degree "cone" - point source with 2 ft at full 10 ft distance. That's the kind of thing we do for flashlights. If that will work for OSE players, we can pop it in on a subsequent drop, possibly along with the swords.

Would you like to work appropriate common light settings for the swords and the Gem?

@Feldherren
Copy link
Author

What amount to appropriate light stats, in this case? I assume they're 360 degrees and 30ft radius; what do you need that is missing, in these cases?

@lupestro
Copy link
Collaborator

Set up the stats that provide a reasonable representation of the kind of light it should be emitting. For instance a flaming sword will probably emit a yellower light than a light sword, which is likely to be whiter. What does "pale" mean for Gem of Radiance? I'm offering you the opportunity to "tell the story" experimentally on a character with the light settings and then funnel them back to me so others can share in them.

The name change just shipped in 2.8.0 this afternoon.

@lupestro lupestro added the enhancement New feature or request label Aug 12, 2023
@Feldherren
Copy link
Author

Sure. I'll be able to work on this in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants