Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

更新leafletCN #12

Open
yiluheihei opened this issue Mar 3, 2020 · 0 comments
Open

更新leafletCN #12

yiluheihei opened this issue Mar 3, 2020 · 0 comments

Comments

@yiluheihei
Copy link

yiluheihei commented Mar 3, 2020

您好,非常感谢您的leafletCN.

因为我用leafletCN画国内地图时,发现json数据可能比较旧,比如有些城市可能已经改名、像北京和天津这种直辖市早已撤县设区。所以我对leafletCN的数据进行了更新,用[这里的数据(https://github.com/wenccro/chinaMapJsonData)替换了原来的地图数据。

另外还伴随了一些小改动:

  • 修改了leafletcn.map.names与更新后地图数据一致
  • 中国地图中加入南海诸岛
  • 把自己处理数据的流程写在了data-raw文件夹下,并添加至.buildignore

我修改后的仓库在, 目前通过R CMD check没有warning。

如果您觉得可以的话,没什么问题,我可以提交个PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant