-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Clean up the horrible build system #82
Comments
There are reasons why it was setup like this.
Sure, it would be nice to migrate to actual dependencies, but this needs a bigger effort. Isn't .deb only for Debian but AppImage for all sorts of Linux? |
My opinion as a newcomer to the project (just my 2 cents, take it only as an opinion):
What about moving the API to something more resilient as golang? Is that of any interest to you? It would provide a better build system, a better security (code wise), a single file build without dependencies to run cross platform, less dependency hell... I wouldn't mind to work on that new version and research on how we could do it slowly. .deb is used also by ubuntu systems I think |
I know I'm replying to a very old issue here, but I'd like to share the work on the build system that I've recently done, for anyone who may be interested: https://github.com/malcolmmp/LaserWeb4-Binaries/tree/electron-builder I also made a post about it on the makerforums website here: https://forum.makerforums.info/t/building-lw4-binaries-in-2024/90044 The work is by no means complete or ready for mainline, but it does build cleanly on Lin/Win/Mac with Node 22. I essentially pulled in the latest versions of everything, added some of the work done for edmweb, and then ported and updated the electron_builder specific stuff over to LaserWeb4-Binaries. If it's of interest, I'd love to clean up the messy bits and submit some pull requests! |
TODO: Merge lw.comm-server, lw.comm-server#electron_bundler and LaserWeb4 into one repsitory and remove duplicates.
TODO: Move from npm to yarn.
TODO: Migrate to newer package versions of dependencies (especially electron and electron-builder).
TODO: Implement .deb building for Linux.
The text was updated successfully, but these errors were encountered: