Fix logfile path

[jorgerobles]

As LaserWeb/LaserWeb4#369 @gerwinbrunner

@cprezzi I've tested patch on electron_bundler
At https://github.com/LaserWeb/lw.comm-server/blob/electron_bundler/server.js#L2843

logFile = fs.createWriteStream(path.join(electronApp.getPath('userData'),"logfile.log"));

I've no commited this, as don't know if thas to be other considerations about branches master & electron

[cprezzi]

Yes, that's the problem! If we fix that only in the electron_bundler branch, it will probably be overwritten by a merge with master, but we can't do electron specific stuff in master.

I think this is a bug in electron for iOS, as a filename without path should use relative path which is the installation directory.

[cprezzi]

Is there something like electron compile switches we could use?

[jorgerobles]

I've not found anything on electron-builder

What I would do:

1. Move all the electron related code to other file (app.js ?)
2. Encapsulate server code on an class (object/prototype/singleton, or even nested function) and inject dependencies on construct (like a setLogger function that swallows a modified logFile function)
3. Create a new bootstrap.js file, make it main at package.json.
4. Bootstrap.js reads an .env file git-ignored in the repo, if not exists instances the server.js class and runs. If exists, load the alternative file on env (like app.js), that runs the server.js instance and the electron part.

[tbfleming]

Maybe if(electronApp)?

[cprezzi]

@jorgerobles Isn't that a bit overcomplicated? There must be a simpler solution.

[cprezzi]

Ok, found something to get if app is running inside electron:
if (process.versions.electron) {...

[jorgerobles]

Well is complicated but abstracts enough to update server freely. Proces.. is of course valid

[cheton]

You can also use is-electron to detect if current process is running in Electron.

[cprezzi]

Thank's @cheton! That's even better.

[cprezzi]

@jorgerobles
logFile = fs.createWriteStream(path.join(electronApp.getPath('userData'),"logfile.log")); doesn't seem to work on Win10 electron app. I get now error message, but also no logfile.

[jorgerobles]

Probably is working but saving somwhere else :) El 6 jul. 2017 6:29 p. m., "Claudio Prezzi" <notifications@github.com> escribió:

…

@jorgerobles <https://github.com/jorgerobles> logFile = fs.createWriteStream(path.join(electronApp.getPath(' userData'),"logfile.log")); doesn't seem to work on Win10 electron app. I get now error message, but also no logfile. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABoIYP-3gt0um35LD0tLdw91MzGd8k96ks5sLQtogaJpZM4OPgoR> .

[cprezzi]

Nope, doesn't seem to. I searched the whole drive.
Looks like we need a way to find out if running on Mac 👎 (hate that stuff!)

[tbfleming]

If(Mac) warn("update to an OS with sane APIs")

[cprezzi]

Ok, found that getPath('userData') is delivering the correct path with \ as directory separator on Windows. Still searching why fs.createWriteStream is not working...

[cprezzi]

I had to make if OS dependant with os.platform.

Who could compile the Mac Version and test if the logfile is written now? (needs .env file with LOG_LEVEL=3 in installation folder).