Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern modifiers are not consistent #62

Open
LarsHassler opened this issue Nov 6, 2017 · 0 comments
Open

Pattern modifiers are not consistent #62

LarsHassler opened this issue Nov 6, 2017 · 0 comments
Labels
enhancement feature good first issue

Comments

@LarsHassler
Copy link
Owner

Description

Modifiers on the json files within patternlab are separated by ~ (button~primary.json). But the definition in the patternlab-to-gemini.json config has to be done with - (due to the ids within the markup).
This is not consistent.

Expected behavior

I want to use atoms-button~primary as a key in the patterns section of the patternlab-to-gemini config file.
@LarsHassler LarsHassler changed the title Pattern modifiers are not consisten Pattern modifiers are not consistent Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LarsHassler