Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a command framework #27

Open
SirYwell opened this issue Jul 17, 2021 · 0 comments
Open

Use a command framework #27

SirYwell opened this issue Jul 17, 2021 · 0 comments
Labels
enhancement New feature or request size: large
Milestone

Comments

@SirYwell
Copy link
Member

LandLord has a fair amount of commands. That currently involves a lot of code that is just handling the command input. With a command framework, this part could be reduced. The remaining code concentrates on the actual execution and is easier to read and more maintainable.

There are several command frameworks already used in the minecraft community (acf, cloud). My personal preference is cloud, it allows defining commands using annotations or a builder similar to brigadier and has good brigadier/tab completion support. I'm not opposed looking into other alternatives, but I think reducing the command parsing overhead would be worth the work.

@SirYwell SirYwell added enhancement New feature or request size: large labels Jul 17, 2021
@SirYwell SirYwell added this to the Version 5 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size: large
Projects
None yet
Development

No branches or pull requests

1 participant