Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unnecessarily expensive methods #22

Open
Aurelien30000 opened this issue Jul 14, 2021 · 0 comments · May be fixed by #127
Open

Replace unnecessarily expensive methods #22

Aurelien30000 opened this issue Jul 14, 2021 · 0 comments · May be fixed by #127
Assignees
Labels
enhancement New feature or request size: small

Comments

@Aurelien30000
Copy link
Member

Aurelien30000 commented Jul 14, 2021

Replace some methods retrieving heavy and unused data, such as:

  • Since a getter exists to load and return the chunk of specific IOwnedLand, we should simply return a Set<IOwnedLand> instead of a Map<Chunk, IOwnedLand>.
public interface IWorldGuardManager {
    ...
    Map<Chunk, IOwnedLand> getNearbyLands(Location loc, int offsetX, int offsetZ);
  • Avoid as much as possible working with Bukkit chunks.
@Aurelien30000 Aurelien30000 added enhancement New feature or request size: medium labels Jul 14, 2021
@Aurelien30000 Aurelien30000 self-assigned this Jul 14, 2021
Aurelien30000 added a commit to Aurelien30000/LandLord that referenced this issue Jan 22, 2023
Aurelien30000 added a commit to Aurelien30000/LandLord that referenced this issue Jun 11, 2023
Aurelien30000 added a commit to Aurelien30000/LandLord that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size: small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant