Skip to content

LibWeb: Return custom validity error message in FormAssociatedElement::validation_message() #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+70 −4
Open

LibWeb: Return custom validity error message in FormAssociatedElement::validation_message() #6900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Libraries/LibWeb/HTML/FormAssociatedElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,18 @@ Utf16String FormAssociatedElement::validation_message() const
if (!is_candidate_for_constraint_validation() || satisfies_its_constraints())
return {};

// FIXME:
// 2. Return a suitably localized message that the user agent would show the user if this were the only form
// control with a validity constraint problem. If the user agent would not actually show a textual message in
// such a situation (e.g., it would show a graphical cue instead), then return a suitably localized message that
// expresses (one or more of) the validity constraint(s) that the control does not satisfy. If the element is a
// candidate for constraint validation and is suffering from a custom error, then the custom validity error
// message should be present in the return value.
// expresses (one or more of) the validity constraint(s) that the control does not satisfy.

// If the element is a candidate for constraint validation and is suffering from a custom error, then
// the custom validity error message should be present in the return value.
if (suffering_from_a_custom_error()) {
return Utf16String::from_utf8(m_custom_validity_error_message);
}

// FIXME: Return more specific localized messages
return "Invalid form"_utf16;
}

Expand Down
13 changes: 13 additions & 0 deletions ...cted/wpt-import/html/semantics/forms/constraints/form-validation-validity-customError.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Harness status: OK

Found 8 tests

8 Pass
Pass [input] The validity.customError must be true if the custom validity error message is not empty
Pass [input] The validity.customError must be false if the custom validity error message is empty
Pass [button] The validity.customError must be true if the custom validity error message is not empty
Pass [button] The validity.customError must be false if the custom validity error message is empty
Pass [select] The validity.customError must be true if the custom validity error message is not empty
Pass [select] The validity.customError must be false if the custom validity error message is empty
Pass [textarea] The validity.customError must be true if the custom validity error message is not empty
Pass [textarea] The validity.customError must be false if the custom validity error message is empty
48 changes: 48 additions & 0 deletions ...put/wpt-import/html/semantics/forms/constraints/form-validation-validity-customError.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>The constraint validation API Test: element.validity.customError</title>
<link rel="author" title="Intel" href="http://www.intel.com/">
<link rel="help" href="https://html.spec.whatwg.org/multipage/#dom-validitystate-customerror">
<link rel="help" href="https://html.spec.whatwg.org/multipage/#the-constraint-validation-api">
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<script src="support/validator.js"></script>
<div id="log"></div>
<script>
var testElements = [
{
tag: "input",
types: [],
testData: [
{conditions: {message: "My custom error"}, expected: true, name: "[target] The validity.customError must be true if the custom validity error message is not empty"},
{conditions: {message: ""}, expected: false, name: "[target] The validity.customError must be false if the custom validity error message is empty"}
]
},
{
tag: "button",
types: [],
testData: [
{conditions: {message: "My custom error"}, expected: true, name: "[target] The validity.customError must be true if the custom validity error message is not empty"},
{conditions: {message: ""}, expected: false, name: "[target] The validity.customError must be false if the custom validity error message is empty"}
]
},
{
tag: "select",
types: [],
testData: [
{conditions: {message: "My custom error"}, expected: true, name: "[target] The validity.customError must be true if the custom validity error message is not empty"},
{conditions: {message: ""}, expected: false, name: "[target] The validity.customError must be false if the custom validity error message is empty"}
]
},
{
tag: "textarea",
types: [],
testData: [
{conditions: {message: "My custom error"}, expected: true, name: "[target] The validity.customError must be true if the custom validity error message is not empty"},
{conditions: {message: ""}, expected: false, name: "[target] The validity.customError must be false if the custom validity error message is empty"}
]
}
]

validator.run_test(testElements, "customError");
</script>