LibWeb: Return custom validity error message in FormAssociatedElement::validation_message() #6900
+70
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
CarlosEduR
force-pushed
the
libweb-fix-validation-message-custom-error
branch
3 times, most recently
from
b5ec3d3 to
69188ae
Compare
Previously, validation_message() always returned a hardcoded "Invalid form" string, now it correctly returns the custom validity error message when the element is suffering from a custom error. Other validation errors still return the "Invalid form" message.
CarlosEduR
force-pushed
the
libweb-fix-validation-message-custom-error
branch
from
74da874 to
abba019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, validation_message() was always returning a hardcoded "Invalid form" string, now it correctly returns the custom validity error message when the element is suffering from a custom error. Other validation errors still return the "Invalid form" message.
Fixes remaining failing tests in: https://wpt.live/html/semantics/forms/constraints/form-validation-validity-customError.html