Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Object state after sending invoking webhook (bug?) #1

Open
scrummer opened this issue Jan 25, 2022 · 0 comments · May be fixed by #2
Open

Reset Object state after sending invoking webhook (bug?) #1

scrummer opened this issue Jan 25, 2022 · 0 comments · May be fixed by #2
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@scrummer
Copy link
Member

Current state

As the various clients are being saved as service within the symfony container it becomes absolutely necessary that the services are being reset after the webhook was invoked.
If not, it can cause issues like contents being sent several times when invoking the same client with other content from an other part of the code.

Desired solution

After DiscordWebook::send() was invoked, all the properties (exclusive the ones configured via Symfony configuration) must be reset to the initial state (e.g. clear message, file(s) and remove all embeds from embeds-collection).

@scrummer scrummer added bug Something isn't working enhancement New feature or request labels Jan 25, 2022
@scrummer scrummer self-assigned this Jan 25, 2022
@scrummer scrummer linked a pull request Jan 25, 2022 that will close this issue
scrummer added a commit that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant