Wrong type hint for the image shape argument #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was specified as Tuple[int, int], can also be Tuple[int, int, int] for color images. Changed to Tuple[int, int] | Tuple[int, int, int]
WeisLeDocto
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
CameraBlock andCameraProcessclass, theimg_shapeargument was type-hinted asTuple[int, int]. This was correct for gray level images, but incorrect for color images.With this PR, the type hints are updated to
Union[Tuple[int, int], Tuple[int, int, int]]to also consider the image colors.