Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet private data should hold all info to allow reconstructing original of invalid packets #7

Open
francois-normandin opened this issue Jan 9, 2024 · 0 comments

Comments

@francois-normandin
Copy link
Member

Current Packet Private Data does not hold the source bytes in a way that allow recreating the original incoming bytes if we detect an invalid packet format.

Packet should hold an original copy of the input stream instead of only caching the result of the decoding.
Use invalid packet type 00 to output invalid source stream when called.

In a nutshell, this is incorrect when the validation fails.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant