Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom skip/include lists #141

Open
seanrjohnson opened this issue Sep 21, 2022 · 3 comments
Open

custom skip/include lists #141

seanrjohnson opened this issue Sep 21, 2022 · 3 comments

Comments

@seanrjohnson
Copy link

It would be nice to be able to skip the .git folders but not skip all non-tracked files.

In my case, I have some singularity .sif containers which are the executables for my workflow, so I need them to be copied/symlinked into the test directory. But they are not part of my git repo (I track the Singularity.def files and rebuild the sif files on target machines as needed).

using --ga skips the .git folders (which is good for me), but also skips the .sif files (which is bad for me). Is there a good workaround for this? My current workaround is just to not use --ga, but that seems inefficient because it's staging a whole bunch of files I don't need.

@rhpvorderman
Copy link
Member

How is the performance, with --symlink? Is that acceptable?
Can you do a find | wc -l and a git ls-files |wc -l for comparison? Can you give me some numbers on the time that tests take to run with and without --ga?

Adding another feature will increase the complexity of the project. If the current functionality leads to considerable slowdowns than it is something worth considering, depending on the costs. So I need a bit more numbers before I can make a good judgement.

@seanrjohnson
Copy link
Author

With --symlink, the performance seems fine. So probably not urgent so support something like this. Thanks.

@rhpvorderman
Copy link
Member

Thanks for reporting back on this. Since --symlink does solve your issues for now, custom exclude lists will not be implemented. The primary argument being that custom exclude lists will be a complicated addition to the code. I will leave this issue open in case more use cases for custom exclude lists arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants