Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code commented out #89

Open
Catarina-Alves opened this issue Mar 22, 2019 · 1 comment
Open

Code commented out #89

Catarina-Alves opened this issue Mar 22, 2019 · 1 comment
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. unit tests To add or modify tests

Comments

@Catarina-Alves
Copy link
Collaborator

snfeatures_test.py has much code commented out. I propose to either delete it or uncomment it.

@Catarina-Alves Catarina-Alves added enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. unit tests To add or modify tests labels Mar 22, 2019
@rbiswas4
Copy link
Member

In this module, most of the code that is commented out can be removed. But it would be good if we can get this part of the test working, rather than removing it:

#   err=compare_images('tsne_plot_test.png', 'tsne_plot_truth.png', tol=1.e-3)

 #   if err:
 #       raise ImageComparisonFailure(err)

I believe @rlschuhmann wrote that code, and what it does is check that the new plot matches the old plot to some level of tolerance. (I think it would be nice to keep this kind of code somewhere. I suspect that in this instance the problem is that tsne plots are not deterministic, so this is failing, but I wonder if there is something like a random seed or state. @rlschuhmann ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. unit tests To add or modify tests
Projects
None yet
Development

No branches or pull requests

2 participants