Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make utils package a subpackage #258

Closed
heather999 opened this issue Oct 21, 2021 · 4 comments
Closed

make utils package a subpackage #258

heather999 opened this issue Oct 21, 2021 · 4 comments
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods.

Comments

@heather999
Copy link
Contributor

As discussed on desc-help, we are going to make utils a subpackage and update the pypi installation appropriately.

@Catarina-Alves Catarina-Alves added the enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. label Oct 21, 2021
@heather999
Copy link
Contributor Author

Dear @Catarina-Alves I'm sorry for the long delay - I have started to look at this again and will try to get back to you early next week!

@Catarina-Alves
Copy link
Collaborator

Hi @heather999, have you had some time to look at this? Thank you

@heather999
Copy link
Contributor Author

Looking at it now! I find part of the issue is that there is old code under snmachine/utils/archive which I believe is no longer relevant. I am moving that archive directory aside and placing it back at the top-level of this repo.. then I am able to do a editable pip install using this copy of the code and run some of the example notebooks... with some minor modification now that utils is a subpackage of snmachine. So I am modifying things to look like:
from snmachine.utils.plasticc_pipeline import get_directories, load_dataset
I recall you didn't need to do that when you tested against the original PR, but I still think that is necessary. I'll update the PR and we can both test this out again (and hopefully finally close this!)

@Catarina-Alves
Copy link
Collaborator

Solved by #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods.
Projects
None yet
Development

No branches or pull requests

2 participants