Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goodness_of_fit deprecated #135

Open
Catarina-Alves opened this issue May 16, 2019 · 4 comments
Open

goodness_of_fit deprecated #135

Catarina-Alves opened this issue May 16, 2019 · 4 comments
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. low priority A "nice-to-have" low priority issue than can be tackled anytime. No rush for implementation unit tests To add or modify tests

Comments

@Catarina-Alves
Copy link
Collaborator

Catarina-Alves commented May 16, 2019 •
edited
Loading

goodness_of_fit is a snfeatures function that should be replaced by some reduced X^2/datapoints funtion.
This function is also used in the tests so it is still a bit of work to change it.
@Catarina-Alves Catarina-Alves added enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. unit tests To add or modify tests low priority A "nice-to-have" low priority issue than can be tackled anytime. No rush for implementation labels May 16, 2019
@tallamjr
Copy link
Collaborator

tallamjr commented Jun 3, 2019

Is it easy enough to just change the function call to the new Chi^2 function?

@Catarina-Alves
Copy link
Collaborator Author

We could do that but it wouldn't be very good as you want to minimize the number of different names used to refer to the same thing

@tallamjr
Copy link
Collaborator

tallamjr commented Jun 3, 2019

Exactly, have just one function, and call that..

@Catarina-Alves
Copy link
Collaborator Author

Ah ok. We also need to change the tests.
Additionally, the function is called in other classes that I haven't worked with so it will make them break as the inputs now needed are a bit different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. low priority A "nice-to-have" low priority issue than can be tackled anytime. No rush for implementation unit tests To add or modify tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tallamjr @Catarina-Alves