-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement the Plasticc pipeline functionalities into snmachine [RFC] #111
Comments
@Catarina-Alves can you comment on which functions you find most useful in the |
The ones I find more useful (not all will be fit to put into
|
As requested in here, the proposal for this feature will be to bring several useful functions. The functions that will be migrated are:
@MichelleLochner , @rbiswas4 , @Catarina-Alves Please respond to this for comments on which functions users would like and for a discussion on best place certain functions should live. For example, should they all be housed in a new |
I think I'd propose these could all go into one of two modules: |
With the majority of the above being merged into |
There are several useful functions in
pipeline.py
(https://github.com/tallamjr/plasticc/blob/develop/pipeline.py).I propose copying them to
snmachine
. I think most of them would fit well inanalysis.py
as they are usefull in analysing the data/ saving the analysis we did.The text was updated successfully, but these errors were encountered: