Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test for algos #7

Closed
raphaelshirley opened this issue Mar 26, 2024 · 3 comments · Fixed by #22
Closed

Create test for algos #7

raphaelshirley opened this issue Mar 26, 2024 · 3 comments · Fixed by #22
Assignees

Comments

@raphaelshirley
Copy link
Collaborator

We need a short unit test to test the informer and the estimator. Perhaps we can use the same example table as for rail_bpz.

@raphaelshirley raphaelshirley self-assigned this Mar 26, 2024
@sschmidt23
Copy link

Just a note that the BPZ informer is doing something different than LePhare: the BPZ inform stage is actually training a Bayesian prior and outputting that parameterized model to be saved. It is not loading any templates or anything like that, those bits are done in the estimate stage. Just pointing out the difference, and that it might affect how you set things up.

@raphaelshirley
Copy link
Collaborator Author

Thanks that is an interesting difference. I actually saw that bpz was training a prior and thought that was an interesting idea for us to try as well. I will consider adding the template processing to the estimator stage. I had thought that the informer stage would do everything required for all objects and that estimate did all the per object processing but I will reconsider...

@sschmidt23
Copy link

I think it's just a design choice as to where to load things, I can see it making sense either way as to where to load and store the templates. The main reason that I set things up the way I did was because the current version does not use the templates directly, and thus I can run the inform stage without loading the templates at all. In the future I might modify things to add in a stage where I classify the spec-z galaxies based on the templates, at which point things might change to something more like what LePhare is doing. But, for now, the way I have things implemented was way faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants