Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redshift grid consistent #43

Closed
3 tasks done
raphaelshirley opened this issue May 15, 2024 · 2 comments · Fixed by #47
Closed
3 tasks done

Make redshift grid consistent #43

raphaelshirley opened this issue May 15, 2024 · 2 comments · Fixed by #47
Assignees
Labels
bug Something isn't working

Comments

@raphaelshirley
Copy link
Collaborator

raphaelshirley commented May 15, 2024

Bug report

lephare defines the redshift grid in the config para file. RAIL additionally specifies the grid via stage params. Shall I overwrite the config values so that the grid can be set through RAIL params? Presently rail_lephare is using the values in the config file which could be inconsistent.

@aimalz What do you think?

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@raphaelshirley raphaelshirley added the bug Something isn't working label May 15, 2024
@raphaelshirley raphaelshirley self-assigned this May 15, 2024
@aimalz
Copy link

aimalz commented May 15, 2024

Good catch! It would be best for users to specify this kind of thing when creating the stage. That's probably true for everything in the config file; ideally, the config file could be written by the stage to which its parameters are provided so RAIL users could run LePhare without a separate config outside of RAIL stage arguments. Does that make sense?

@raphaelshirley
Copy link
Collaborator Author

Yes definitely makes sense I will overwrite the lephare config and think about warning the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants