Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all intermediate file contents in model file. #32

Open
drewoldag opened this issue May 13, 2024 · 0 comments
Open

Include all intermediate file contents in model file. #32

drewoldag opened this issue May 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@drewoldag
Copy link
Collaborator

Currently rail_lephare produces several intermediate files as part of the Inform stage. These files are saved to disk and read in during the Evaluation stage using environmental variables that define their parent directory locations.

This isn't typical in RAIL - usually the model file would contain all of the information (with the exception of input data) that is required for redshift estimation. Often running the inform stage for other algorithms is computationally intensive and thus, it is convenient to be able to share the resulting single model file easily.

However, rail_lephare's inform stage is relatively lightweight, so the benefit of packaging everything into the model file (as well as writing and maintaining the output/input code to support that) isn't as clear.

It probably makes sense to wait a bit to better understand the way that users will typically interact with rail_lephare to determine if this is work would be helpful. If users don't mind running the inform stage prior to each estimate stage, then doing this work probably isn't as useful. Alternatively if repeatedly running the inform stage becomes a burden, then some way of packaging all intermediate data for portability will become more important.

@drewoldag drewoldag added the enhancement New feature or request label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant