Skip to content

Clean up namespacing and static variable declarations. #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
rhornung67 opened this issue Dec 10, 2024 · 0 comments
Open
2 tasks

Clean up namespacing and static variable declarations. #1779

rhornung67 opened this issue Dec 10, 2024 · 0 comments
Labels
help wanted reviewed Mark with this label when issue has been discussed by team task

Comments

@rhornung67
Copy link
Member

We have static variable declarations like this in a SYCL file: https://github.com/LLNL/RAJA/blob/develop/include/RAJA/policy/sycl/reduce.hpp#L74

and like this in an OpenMP target file: https://github.com/LLNL/RAJA/blob/develop/include/RAJA/policy/openmp_target/reduce.hpp#L70

The usage of these variables is essentially the same within those two files, but the declarations are inconsistent.

  • Make static variable declarations consistent, in this example, it seems that the first code link above would be preferred.
  • The namespace scope associated with the variables cited in these code examples is also strange. It seems like sycl::MaxNumTeams should be replaced with RAJA::sycl::MaxNumTeams for clarity. Similarly for the OpenMP target example.
@rhornung67 rhornung67 added this to the FY25 Development milestone Dec 10, 2024
@rhornung67 rhornung67 added the reviewed Mark with this label when issue has been discussed by team label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted reviewed Mark with this label when issue has been discussed by team task
Projects
None yet
Development

No branches or pull requests

1 participant