Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Komorebi bar doesn't support RTL languages (Arabic language) #1089

Closed
H7ioo opened this issue Oct 26, 2024 · 4 comments
Closed

[BUG]: Komorebi bar doesn't support RTL languages (Arabic language) #1089

H7ioo opened this issue Oct 26, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@H7ioo
Copy link

H7ioo commented Oct 26, 2024

Summary

Komorebi RTL text is backward
Komorebi bar: image
expected result: Tariq Elouzeh - مقابلات البرمجة | النسخة المدرسية | مع فايز من فلسطين

So, the text is reversed and not connected

Version Information

OS Name:                   Microsoft Windows 11 Home Single Language
OS Version:                10.0.22631 N/A Build 22631
komorebic 0.1.30
tag:nightly
commit_hash:09afad62
build_time:2024-10-22 14:49:49 +03:00
build_env:rustc 1.82.0 (f6e511eec 2024-10-15),stable-x86_64-pc-windows-msvc

Komorebi Configuration

I'll provide if necessary

Hotkey Configuration

I'll provide if necessary

Output of komorebic check

I'll provide if necessary

@H7ioo H7ioo added the bug Something isn't working label Oct 26, 2024
@LGUG2Z
Copy link
Owner

LGUG2Z commented Oct 26, 2024

I believe this is partially dependent on the font you pick - can you confirm which fonts you have tried?

@H7ioo
Copy link
Author

H7ioo commented Oct 26, 2024

I changed the font to Aldhabi and Dubai but the issue still exists.

"font_family": "Dubai"

image

"font_family": "Aldhabi Regular"

image

image
image

@LGUG2Z
Copy link
Owner

LGUG2Z commented Oct 26, 2024

Thanks for confirming. I'm guessing this is an upstream issue in egui with no action to really be taken in komorebi itself. Will leave this open to return to whenever egui supports connected rtl characters in the future.

@H7ioo
Copy link
Author

H7ioo commented Oct 26, 2024

I assume they are working on it emilk/egui#56. Will be waiting for the RTL support
Thanks for building such wonderful tools!

@H7ioo H7ioo closed this as completed Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants