Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consistency Check for Ridehail Manager Configuration #3782

Open
wrashid opened this issue Sep 23, 2023 · 0 comments
Open

Add Consistency Check for Ridehail Manager Configuration #3782

wrashid opened this issue Sep 23, 2023 · 0 comments

Comments

@wrashid
Copy link
Collaborator

wrashid commented Sep 23, 2023

see

/**
* We need to copy the old config values to the first element of rideHail.managers collection.
* It helps workaround the typesafe config limitation that one cannot access array elements via paths
* like this
* beam.agentsim.agents.rideHail.managers[0].initialization.procedural.fractionOfInitialVehicleFlee
* (https://github.com/lightbend/config/issues/30).
* This update helps working correctly the experiments, old configs.
* If config doesn't have beam.agentsim.agents.rideHail.managers then copying always happens.
* If config has beam.agentsim.agents.rideHail.managers then copying happens only in the case
* beam.cfg.copyRideHailToFirstManager = true is presented in the config
*/

If beam.cfg.copyRideHailToFirstManager = true is not set, then a warning should be logged during the configuration consistency check stage, if both the root ridehail manager and the array manager is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant